-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Frames and User Image Invalidation #1604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeb01
commented
May 24, 2024
•
edited
Loading
edited
- Support the ability to allow a user to invalidate an image within a subscription.
- Report error frames for publications back to the client.
mikeb01
force-pushed
the
feature/error_frames
branch
from
June 12, 2024 04:32
ce58a33
to
6bda98e
Compare
mikeb01
changed the title
User Image Invalidation
Error Frames and User Image Invalidation
Jun 13, 2024
mikeb01
force-pushed
the
feature/error_frames
branch
from
June 18, 2024 00:57
5f4396c
to
574e267
Compare
aeron-driver/src/main/java/io/aeron/driver/status/SystemCounterDescriptor.java
Outdated
Show resolved
Hide resolved
mikeb01
force-pushed
the
feature/error_frames
branch
from
June 27, 2024 04:30
cb113e8
to
e6f62bb
Compare
mjpt777
reviewed
Jul 4, 2024
mjpt777
reviewed
Jul 4, 2024
mjpt777
reviewed
Jul 4, 2024
mjpt777
reviewed
Jul 4, 2024
aeron-client/src/main/java/io/aeron/protocol/ErrorFlyweight.java
Outdated
Show resolved
Hide resolved
mjpt777
reviewed
Jul 4, 2024
aeron-driver/src/main/java/io/aeron/driver/status/SystemCounterDescriptor.java
Outdated
Show resolved
Hide resolved
mikeb01
force-pushed
the
feature/error_frames
branch
from
July 23, 2024 02:28
ba3a373
to
283400f
Compare
mikeb01
force-pushed
the
feature/error_frames
branch
from
August 2, 2024 03:35
e5595ba
to
0129e9a
Compare
mikeb01
force-pushed
the
feature/error_frames
branch
from
August 19, 2024 22:16
235ce94
to
602b76e
Compare
mikeb01
force-pushed
the
feature/error_frames
branch
from
August 28, 2024 23:44
602b76e
to
0ace362
Compare
vyazelenko
requested changes
Aug 29, 2024
aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java
Outdated
Show resolved
Hide resolved
…ode. Prevent new data being inserted into an invalidated image. Add logging.
…e is found during invalidation on the receiver.
… have it disconnect. Allow receiver side image to linger to prevent immediately recreation of the image. Treat errors received by the NetworkPublication to behaviour like end of stream messages.
…t send max frame size each time.
…cifically with error frames for publications. Add test to verify that it works for exclusive publications.
…. Also add copy and move constructors for dealing with the limit lifecycle of callback objects.
…within the client conductor.
… to all clients with the same publication and not to ones that without it.
mikeb01
force-pushed
the
feature/error_frames
branch
from
September 2, 2024 02:38
55e8be6
to
fb7641c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.