Tethering join position #1672
Merged
Tethering join position #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyazelenko
pushed a commit
to vyazelenko/aeron
that referenced
this pull request
Oct 24, 2024
* [Java] Fix java tethering join position * [C] Align c with java publication image tethering join position * [Java] Fix join position of tethered subscriptions * [C] Align C tethering with java * [Java] Add position check to untethered system test * [Java] checkstyle (cherry picked from commit 297f69c)
vyazelenko
pushed a commit
that referenced
this pull request
Oct 24, 2024
* [Java] Fix java tethering join position * [C] Align c with java publication image tethering join position * [Java] Fix join position of tethered subscriptions * [C] Align C tethering with java * [Java] Add position check to untethered system test * [Java] checkstyle (cherry picked from commit 297f69c)
vyazelenko
pushed a commit
that referenced
this pull request
Oct 25, 2024
* [Java] Fix java tethering join position * [C] Align c with java publication image tethering join position * [Java] Fix join position of tethered subscriptions * [C] Align C tethering with java * [Java] Add position check to untethered system test * [Java] checkstyle (cherry picked from commit 297f69c)
|
Hi @marc-adaptive Did you notice some misbehavior due to this rejoining at an old position? I'm investigating |
|
@callmerockett Yes an untethered subscription could rejoin at an invalid position. Could you please try again using the latest driver from 1.44.6, 1.45.1, 1.46.7, or master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For untethered subscriptions transitioning from resting to active, avoid using their own position in minimum join position