Explicitly instantiate Table::find_first #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of overloads of `Table::find_first` were not making it into the prebuilt core release for Node. Adding explicit instantiations ensures they do.
|
Please check your coverage here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2624/1/Diff_Coverage |
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2624/1/Performance_Report |
|
👍 |
finnschiermer
approved these changes
May 23, 2017
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2624/2/Performance_Report |
|
Please check your coverage here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2624/2/Diff_Coverage |
bdash
added a commit
that referenced
this pull request
Aug 28, 2017
Other explicit instantiations were added in #2624, but `BinaryData` was overlooked.
jedelbo
pushed a commit
that referenced
this pull request
Aug 30, 2017
Other explicit instantiations were added in #2624, but `BinaryData` was overlooked.
fealebenpae
pushed a commit
that referenced
this pull request
Sep 6, 2017
Other explicit instantiations were added in #2624, but `BinaryData` was overlooked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of overloads of
Table::find_firstwere not making it into the prebuilt core release for Node. Adding explicit instantiations ensures they do.This is needed for realm/realm-js#1023.