Add support for updating the base url #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaafanador3
force-pushed
the
dp/base_url
branch
from
2d48380 to
355eeac
Compare
nielsenko
reviewed
May 7, 2024
nielsenko
reviewed
May 7, 2024
dianaafanador3
force-pushed
the
dp/base_url
branch
4 times, most recently
from
eee1ef4 to
7a7b6ff
Compare
dianaafanador3
force-pushed
the
dp/base_url
branch
from
7a7b6ff to
332da95
Compare
dianaafanador3
force-pushed
the
dp/base_url
branch
from
98d2f5b to
e695db2
Compare
leemaguire
reviewed
May 19, 2024
There was a problem hiding this comment.
The CMake GHA workflows will also need -DREALM_ENABLE_EXPERIMENTAL=1 passed when generating the build files for sync tests, e.g
realm-cpp/.github/workflows/cmake.yml
Line 348 in e718cc8
leemaguire
reviewed
May 21, 2024
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| ### Enhancements | |||
| * Updated default base URL to be `https://services.cloud.mongodb.com` to support the new domains (was `https://realm.mongodb.com`) | |||
| * Added support for updating Atlas Device Sync's base url, in case the need to roam between servers (cloud and/or edge server). | |||
There was a problem hiding this comment.
You need to explain how to opt into the API
leemaguire
approved these changes
May 24, 2024
Co-authored-by: Lee Maguire <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for updating Atlas Device Sync's base url, in case the need to roam between servers (cloud and/or edge server).