Skip to content

Commit

Permalink
Merge branch 'master' into ni/android-tests
Browse files Browse the repository at this point in the history
* master:
  Update to latest core (#2679)
  Bring back the win81 tests (#2682)

# Conflicts:
#	wrappers/realm-core
  • Loading branch information
nirinchev committed Oct 18, 2021
2 parents 1de71aa + 162c9d5 commit 0ae68d0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/templates/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ macos-latest, windows-latest, ubuntu-latest ]
os: [ macos-latest, windows-latest, ubuntu-latest, win81 ]
targetFramework: [ netcoreapp3.1, net5.0, net6.0 ]
steps:
- name: Cleanup Workspace
Expand All @@ -507,7 +507,7 @@ jobs:
- uses: #@ actionSetupDotnet
if: matrix.targetFramework == 'net6.0'
with:
dotnet-version: '6.0.100-preview.7.21379.14'
dotnet-version: '6.0.x'
include-prerelease: true
- #@ template.replace(dotnetPublishAndRunTests("Tests/Realm.Tests", "${{ matrix.targetFramework }}", "Realm.Tests --result=TestResults.xml --labels=After"))
- #@ publishTestsResults("TestResults.xml", ".NET (${{ matrix.os }}, ${{ matrix.targetFramework }})")
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ jobs:
- macos-latest
- windows-latest
- ubuntu-latest
- win81
targetFramework:
- netcoreapp3.1
- net5.0
Expand Down Expand Up @@ -623,7 +624,7 @@ jobs:
- uses: actions/setup-dotnet@v1
if: matrix.targetFramework == 'net6.0'
with:
dotnet-version: 6.0.100-preview.7.21379.14
dotnet-version: 6.0.x
include-prerelease: true
- name: Publish Tests/Realm.Tests
run: dotnet publish Tests/Realm.Tests -c Release -f ${{ matrix.targetFramework }} -r ${{ (runner.os == 'macOS' && 'osx-x64') || (runner.os == 'Windows' && 'win-x64') || (runner.os == 'Linux' && 'linux-x64') || '???' }} -p:AdditionalFrameworks=${{ matrix.targetFramework }} -p:RestoreConfigFile=Tests/Test.NuGet.Config -p:UseRealmNupkgsWithVersion=${{ needs.build-packages.outputs.package_version }} --no-self-contained
Expand Down
2 changes: 1 addition & 1 deletion wrappers/realm-core
Submodule realm-core updated 114 files
4 changes: 3 additions & 1 deletion wrappers/src/sync_user_cs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include <realm/object-store/sync/app.hpp>
#include "app_cs.hpp"

#include <external/json/json.hpp>

using namespace realm;
using namespace realm::binding;
using namespace app;
Expand Down Expand Up @@ -228,7 +230,7 @@ extern "C" {
REALM_EXPORT SharedApp* realm_syncuser_get_app(SharedSyncUser& user, NativeException::Marshallable& ex)
{
return handle_errors(ex, [&] {
// If the user is detached from the sync manager, we'll hit an assert, so this early check avoids that.
// If the user is detached from the sync manager, we'll hit an assert, so this early check avoids that.
if (user->state() != SyncUser::State::Removed)
{
if (auto shared_app = user->sync_manager()->app().lock()) {
Expand Down

0 comments on commit 0ae68d0

Please sign in to comment.