Skip to content

Commit

Permalink
PR review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nirinchev committed Jun 29, 2021
1 parent e2ba2f0 commit 45050cd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
## vNext (TBD)

### Fixed
* \[Unity] Fixed an issue where failing to weave an assembly due to modeling errors, would only show an error in the logs once and then fail opening a Realm with `No RealmObjects. Has linker stripped them?`. Now, the weaving errors will show up on every code change/weave attempt and the runtime error will explicitly suggest manually re-running the weaver. (Issue [#2310](https://github.com/realm/realm-dotnet/issues/2310))
* \[Unity] Fixed an issue that would cause the app to hang on exit when using Sync. (PR [#2467](https://github.com/realm/realm-dotnet/pull/2467))
* \[Unity\] Fixed an issue where failing to weave an assembly due to modeling errors, would only show an error in the logs once and then fail opening a Realm with `No RealmObjects. Has linker stripped them?`. Now, the weaving errors will show up on every code change/weave attempt and the runtime error will explicitly suggest manually re-running the weaver. (Issue [#2310](https://github.com/realm/realm-dotnet/issues/2310))
* \[Unity\] Fixed an issue that would cause the app to hang on exit when using Sync. (PR [#2467](https://github.com/realm/realm-dotnet/pull/2467))
* \[Unity\] Fixed an issue that would cause the Unity editor on macOS to hang after assembly reload if the app uses Sync. (Issue [#2482](https://github.com/realm/realm-dotnet/issues/2482))

### Enhancements
* None
Expand Down
6 changes: 2 additions & 4 deletions Realm/Realm/Handles/AppHandle.cs
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,8 @@ public static void ForceCloseHandles()
{
foreach (var weakHandle in _appHandles)
{
if (weakHandle.Target is AppHandle handle)
{
handle?.Close();
}
var appHandle = (AppHandle)weakHandle.Target;
appHandle?.Close();
}

_appHandles.Clear();
Expand Down
2 changes: 1 addition & 1 deletion wrappers/realm-core
Submodule realm-core updated 50 files
+112 −87 CHANGELOG.md
+1 −3 Jenkinsfile
+0 −1 evergreen/config.yml
+1 −1 how-to-build.md
+3 −0 src/realm/data_type.hpp
+11 −3 src/realm/db.cpp
+9 −0 src/realm/list.cpp
+2 −0 src/realm/list.hpp
+19 −5 src/realm/obj.cpp
+38 −33 src/realm/object-store/impl/deep_change_checker.cpp
+7 −1 src/realm/object-store/impl/deep_change_checker.hpp
+5 −0 src/realm/object-store/shared_realm.cpp
+7 −4 src/realm/object-store/sync/impl/sync_client.hpp
+1 −1 src/realm/object-store/sync/sync_manager.cpp
+26 −7 src/realm/object-store/sync/sync_session.cpp
+9 −0 src/realm/set.cpp
+2 −0 src/realm/set.hpp
+38 −22 src/realm/util/file.cpp
+8 −5 src/realm/util/file.hpp
+7 −0 src/realm/util/logger.hpp
+0 −1 test/object-store/mongodb/.gitignore
+0 −6 test/object-store/mongodb/auth_providers/anon-user.json
+0 −6 test/object-store/mongodb/auth_providers/api-key.json
+0 −9 test/object-store/mongodb/auth_providers/custom-function.json
+0 −17 test/object-store/mongodb/auth_providers/local-userpass.json
+0 −14 test/object-store/mongodb/config.json
+0 −6 test/object-store/mongodb/functions/authFunc/config.json
+0 −17 test/object-store/mongodb/functions/authFunc/source.js
+0 −6 test/object-store/mongodb/functions/confirmFunc/config.json
+0 −49 test/object-store/mongodb/functions/confirmFunc/source.js
+0 −6 test/object-store/mongodb/functions/resetFunc/config.json
+0 −51 test/object-store/mongodb/functions/resetFunc/source.js
+0 −6 test/object-store/mongodb/functions/sumFunc/config.json
+0 −3 test/object-store/mongodb/functions/sumFunc/source.js
+0 −3 test/object-store/mongodb/graphql/config.json
+0 −4 test/object-store/mongodb/secrets.json
+0 −23 test/object-store/mongodb/services/BackingDB/config.json
+0 −35 test/object-store/mongodb/services/BackingDB/rules/test_data.Dog.json
+0 −54 test/object-store/mongodb/services/BackingDB/rules/test_data.Person.json
+0 −15 test/object-store/mongodb/services/BackingDB/rules/test_data.testRemoteMongoClient.json
+0 −12 test/object-store/mongodb/services/gcm/config.json
+137 −0 test/object-store/primitive_list.cpp
+12 −0 test/object-store/realm.cpp
+290 −206 test/object-store/sync/app.cpp
+202 −18 test/object-store/transaction_log_parsing.cpp
+66 −7 test/object-store/util/baas_admin_api.cpp
+11 −1 test/object-store/util/baas_admin_api.hpp
+13 −8 test/test_shared.cpp
+25 −0 test/test_typed_links.cpp
+86 −0 test/test_util_to_string.cpp

0 comments on commit 45050cd

Please sign in to comment.