Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cope with Core 0.96.1 breaking API changes #393

Closed
AndyDentFree opened this issue Feb 12, 2016 · 1 comment
Closed

cope with Core 0.96.1 breaking API changes #393

AndyDentFree opened this issue Feb 12, 2016 · 1 comment
Assignees
@AndyDentFree
Labels
T-Bug

Comments

@AndyDentFree
Copy link
Contributor

Building wrappers fails, first error:

In file included from /Users/andydent/dev/Realm/realm-dotnet/wrappers/src/object-store/impl/transact_log_handler.cpp:23:
In file included from core/include/realm/commit_log.hpp:27:
In file included from core/include/realm/replication.hpp:36:
core/include/realm/impl/transact_log.hpp:1499:75: error: too many arguments to
      function call, expected 3, have 4
  ...if (!handler.set_int_unique(col_ndx, row_ndx, prior_num_rows, value)) /...

These are probably fixes in ObjectStore needing merging across as we shift to that core version.
@AndyDentFree AndyDentFree self-assigned this Feb 24, 2016
AndyDentFree added a commit that referenced this issue Feb 24, 2016
@AndyDentFree
#393 Update to Core 0.96.1 breaking changes
3cce1b7 
Makefile
- bumped core version to 0.96.2
@AndyDentFree
Copy link
Contributor Author

Confirmed this includes not only massive ObjectStore fixes but also a restructuring of ObjectStore pushing the stuff we were pulling as a subtree down into a src folder.

AndyDentFree added a commit that referenced this issue Feb 25, 2016
@AndyDentFree
Merge branch 'master' into ad/feature/core/cope-0.96.1-breaking/#393
3152d9d 
* master:
  Minor makefile fixes
  Update makefiles
  Update IDE project files
  Update paths in #include directives
  Update object store
  #404 Add way to specify encryption key

# Conflicts:
#	internals/Realm-dotnet Code Change Diary - Andy Dent.txt
#	wrappers/Makefile
AndyDentFree added a commit that referenced this issue Feb 25, 2016
@AndyDentFree
#393 Update to Core 0.96.1 breaking changes
31490e3 
Makefile
- bumped core version to 0.96.2
AndyDentFree added a commit that referenced this issue Feb 25, 2016
@AndyDentFree
Merge commit '565e39a287bc625fd27e724c28e999e891ca8df6' into ad/featu…
d9f890f 
…re/core/cope-0.96.1-breaking/#393

# Conflicts:
#	wrappers/src/object-store/CMake/RealmCore.cmake
#	wrappers/src/object-store/CMakeLists.txt
#	wrappers/src/object-store/src/impl/cached_realm.hpp
#	wrappers/src/object-store/src/impl/external_commit_helper.hpp
#	wrappers/src/object-store/src/impl/realm_coordinator.hpp
#	wrappers/src/object-store/src/impl/transact_log_handler.cpp
#	wrappers/src/object-store/src/list.cpp
#	wrappers/src/object-store/src/list.hpp
#	wrappers/src/object-store/src/parser/parser.cpp
#	wrappers/src/object-store/src/parser/query_builder.cpp
#	wrappers/src/object-store/src/parser/test.sh
#	wrappers/src/object-store/src/shared_realm.cpp
#	wrappers/src/object-store/tests/CMakeLists.txt
AndyDentFree added a commit that referenced this issue Feb 25, 2016
@AndyDentFree
#393 Update to Core 0.96.1- correct diary note
b2b512c 
correctly refer to the ObjectStore branch included and update Changelog.md to match
AndyDentFree added a commit that referenced this issue Feb 26, 2016
@AndyDentFree
Merge pull request #410 from realm/ad/feature/core/cope-0.96.1-breaking/
ddde394 
#393

Ad/feature/core/cope 0.96.1 breaking/#393
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyDentFree AndyDentFree

Labels
T-Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristiandupont @AndyDentFree