Build wrappers on Github Actions #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add typescript to dependencies * Add some basic eslint rules (will extend later) * Add typings to package.json * Add __tests__ to tsc includes * Disable the unused var warnings for tests
* Indent code with 4 spaces * Increase print-width
nirinchev
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Did a very cursory review of the public API of ga_packages/build_cache_executor and think we should simplify it. We shouldn't try and provide too much flexibility in the first iteration because we don't know if people will actually need it. Let's go with the absolute simplest solution and build on top of that rather than the other way around. Happy to pair on some of that so that we align faster.
.github/ga_packages/build_cache_executor/src/build_cache_executor.ts
Outdated
Show resolved
Hide resolved
* wip * Supply input and output paths to the action * Add ncc * Fix the action metadata * Tweak the build wrappers command * Try to simplify configuration passing to bash builds * Bump down ubuntu version for android * Try and use ytt for templates * Remove the `null` from PR * Try #3 * Try #4 * Try 5 * Try 6 * Try to use pure workflow * Remove extra brace * Yet another brace * cacheKey -> key * Add the cache condition to any intermediate steps * Revert files that are unrelated to the workflow change * More tweaks to the template * Test building iOS wrappers * Try to build iOS #2 * Bring back the cmake configuration check in ios and android build scripts * Try building linux on bare metal * Use correct ubuntu image * Try to add Android * Put matrix under strategy * Setup NDK env variables * Add $ * Don't download the ndk * Added windows to templates * Try to cache vcpkg * Trigger uncached build * Trigger another uncached build * Another build * Another uncached run * Revert dummy changes * Added UWP to template * Fixed small detail * Added saving output * Always output cacheKey from building wrappers * Removed TODO comment * Ac/retrieve multiple caches ga (#2325) * Added fetching multiple bins * Store binaries as artifacts * Store binaries as artifacts - 2 * Store binaries as artifacts - 3 * Store binaries as artifacts - 4 * Store binaries as artifacts - 5 * PR ready for review Co-authored-by: Andrea Catalini <[email protected]>
nirinchev
changed the title
LaPeste
commented
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build macOS wrappers on every PR push and while at it create actions for code reuse.
To run tests: from relative folder
realm-dotnet/.github/actions/build_wrappersrun$npm test.To build: it depends on where the changes were made
npm run buildfrom that project plus point 1To lint:
npm run lintfrom the project you want to lintTo lint and auto fix:
npm run lint-fixTo debug: in VSCode go under the debug tab and select
A discussion should be held to agree on when and where (locally or remotely) to automatically trigger a test run.
Fixes #2294
Fixes #2280
Fixes #2281
Fixes #2282
Fixes #2283
Fixes #2253
TODO