Disallow counter collections #2350
Conversation
|
All seems to work, I just need to understand why I get an error during testing with |
Realm/Realm.Weaver/RealmWeaver.cs
Outdated
| { | ||
| return WeavePropertyResult.Error($"{type.Name}.{prop.Name} is an {collectionType} but its generic type is {elementType.Name} which is not supported by Realm."); | ||
| if (_counterTypes.Contains(elementType.FullName)) |
There was a problem hiding this comment.
Rather than having a new list of counters, you can check if the type is realm integer by calling elementType.Resolve().IsRealmInteger(out _, out _).
|
If you get the peverify error on master, it's probably not due to your changes :D |
I missed it, has peverify always been there? Or has it been added recently? |
It has been there for long time, and I think I already disabled it somewhere else in the past. |
Yes, I've branched from master :) |
This PR adds an error in the weaver when declaring collections of
RealmInteger.Fixes #2308