Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workaround for xunit tests #2787

Merged
merged 7 commits into from
Jan 28, 2022
Merged

Add a workaround for xunit tests #2787

merged 7 commits into from
Jan 28, 2022

Conversation

nirinchev
Copy link
Member

Description

Fixes #1865

TODO

  • Changelog entry
  • Tests (if applicable)

@nirinchev nirinchev requested a review from fealebenpae January 28, 2022 11:14
@nirinchev nirinchev self-assigned this Jan 28, 2022
@nirinchev nirinchev requested a review from papafe January 28, 2022 11:14
@cla-bot cla-bot bot added the cla: yes label Jan 28, 2022
@coveralls
Copy link

coveralls commented Jan 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1761527957

  • 3 of 22 (13.64%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 82.851%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Native/SynchronizationContextScheduler.cs 3 22 13.64%
Totals Coverage Status
Change from base Build 1759057495: -0.3%
Covered Lines: 5401
Relevant Lines: 6409
💛 - Coveralls

@nirinchev
Copy link
Member Author

The xUnit compatibility tests are run on release only because I don't expect we'll ever cause them to fail and it's a waste of resources to run them continuously. The line coverage drop is expected as these codepaths are not exercised by our regular tests.

@nirinchev nirinchev merged commit 60c629e into master Jan 28, 2022
@nirinchev nirinchev deleted the ni/xunit branch January 28, 2022 12:45
@nirinchev nirinchev mentioned this pull request Jan 28, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

@papafe papafe Awaiting requested review from papafe

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception 'System.Runtime.InteropServices.SEHException'
3 participants
@nirinchev @coveralls @fealebenpae