Add support for AppleTV #3174
Add support for AppleTV #3174
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| case BuildTarget.iOS: | ||
| case BuildTarget.tvOS: | ||
| UpdateiOSFrameworks(false, false, report.summary.platform); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
There was a problem hiding this comment.
This is a false negative - we won't get into this case if report is null.
| UpdateiOSFrameworks( | ||
| enableForDevice: PlayerSettings.iOS.sdkVersion == iOSSdkVersion.DeviceSDK, | ||
| enableForSimulator: PlayerSettings.iOS.sdkVersion == iOSSdkVersion.SimulatorSDK); | ||
| UpdateiOSFrameworks(enableForDevice, enableForSimulator, report.summary.platform); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
There was a problem hiding this comment.
False negative again - if report is null, we would have returned from the method.
| isExplicitlyReferenced: 0 | ||
| validateReferences: 1 | ||
| platformData: | ||
| - first: |
There was a problem hiding this comment.
This file is actually important even though it's kind of difficult to review - it indicates that the tvOS wrappers are disabled on all platforms. This is because they're enabled on build by the logic in UnityWeaver.cs. This is pretty similar to what we're doing with the iOS wrappers.
| return; | ||
| case BuildTarget.iOS: | ||
| case BuildTarget.tvOS: | ||
| UpdateiOSFrameworks(false, false, report.summary.platform); |
There was a problem hiding this comment.
This is a false negative - we won't get into this case if report is null.
|
|
||
| UpdateiOSFrameworks( | ||
| enableForDevice: false, | ||
| enableForSimulator: false); | ||
| } | ||
|
|
||
| public void OnPreprocessBuild(BuildReport report) |
There was a problem hiding this comment.
Similarly to iOS, we need to include the correct framework depending on the target we're building.
| UpdateiOSFrameworks( | ||
| enableForDevice: PlayerSettings.iOS.sdkVersion == iOSSdkVersion.DeviceSDK, | ||
| enableForSimulator: PlayerSettings.iOS.sdkVersion == iOSSdkVersion.SimulatorSDK); | ||
| UpdateiOSFrameworks(enableForDevice, enableForSimulator, report.summary.platform); |
There was a problem hiding this comment.
False negative again - if report is null, we would have returned from the method.
| @@ -109,7 +109,7 @@ | |||
| </None> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' AND '$(UseRealmNupkgsWithVersion)' == ''"> | |||
| <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' AND '$(UseRealmNupkgsWithVersion)' == '' AND '$(RealmTestsStandaloneExe)' == 'true'"> | |||
There was a problem hiding this comment.
Added this to prevent msbuild from complaining when we're building the iOS/tvOS tests without having built the macOS wrappers.
Description
Fixes #3161
TODO