Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypath filtering #3179

Merged
merged 34 commits into from
Jan 20, 2023
Merged

Keypath filtering #3179

merged 34 commits into from
Jan 20, 2023

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jan 13, 2023

Description

Replaces #3121. Putting up a different PR to make sure I don't accidentally overlook something.

TODO

  • Changelog entry
  • Tests (if applicable)

{
EnsureIsOpen();

var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException);
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException);

Check notice

Code scanning / CodeQL

Calls to unmanaged code

Replace this call with a call to managed code if possible.
{
EnsureIsOpen();

var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException);
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException);

Check notice

Code scanning / CodeQL

Calls to unmanaged code

Replace this call with a call to managed code if possible.
{
EnsureIsOpen();

var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException);
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException);

Check notice

Code scanning / CodeQL

Calls to unmanaged code

Replace this call with a call to managed code if possible.
{
EnsureIsOpen();

var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException);
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException);

Check notice

Code scanning / CodeQL

Calls to unmanaged code

Replace this call with a call to managed code if possible.
@nirinchev nirinchev marked this pull request as ready for review January 17, 2023 15:25
Copy link
Contributor

@LaPeste LaPeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the test yet.
About the implementation I think I understand the overall idea and it mostly makes sense to me but I still have a few questions.
I'd like to discuss about this PR this Friday mostly to verify how correct is my understanding.

@nirinchev nirinchev merged commit e5cbebd into main Jan 20, 2023
@nirinchev nirinchev deleted the ni/keypath-filtering branch January 20, 2023 15:24
papafe added a commit that referenced this pull request Jan 27, 2023
* main:
  Survey ad (#3201)
  Workaround Mono yield bug (#3200)
  Bump docker layer caching action to use node16 (#3193)
  Keypath filtering (#3179)
  Move realm files created by tests to current directory on CI (#2991)
  Fix failing sync tests (#3096)
  Updated example project to MAUI and Source Generators (#3168)
  Fix uwp workflow when running in debug (#3177)
  Deprecate push client (#3176)
  Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue (#3175)
  Keep track of the active transaction and close it on realm close (#3164)
  Add more detailed unsupported type error (#3163)
  Build Xamarin.Android tests in all ABIs (#3165)

# Conflicts:
#	Tests/Realm.Tests/Generated/Realm.SourceGenerator/Realms.SourceGenerator.RealmGenerator/ObjectWithPartitionValue_generated.cs
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants