-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keypath filtering #3179
Keypath filtering #3179
Conversation
…fication_callback
…fication callback
# Conflicts: # wrappers/realm-core
{ | ||
EnsureIsOpen(); | ||
|
||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException); | ||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
{ | ||
EnsureIsOpen(); | ||
|
||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException); | ||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
{ | ||
EnsureIsOpen(); | ||
|
||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException); | ||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
{ | ||
EnsureIsOpen(); | ||
|
||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, out var nativeException); | ||
var result = NativeMethods.add_notification_callback(this, managedObjectHandle, shallow, out var nativeException); |
Check notice
Code scanning / CodeQL
Calls to unmanaged code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the test yet.
About the implementation I think I understand the overall idea and it mostly makes sense to me but I still have a few questions.
I'd like to discuss about this PR this Friday mostly to verify how correct is my understanding.
* main: Survey ad (#3201) Workaround Mono yield bug (#3200) Bump docker layer caching action to use node16 (#3193) Keypath filtering (#3179) Move realm files created by tests to current directory on CI (#2991) Fix failing sync tests (#3096) Updated example project to MAUI and Source Generators (#3168) Fix uwp workflow when running in debug (#3177) Deprecate push client (#3176) Don't use reflection in DynamicRealmObjectHelper.TryGetPrimaryKeyValue (#3175) Keep track of the active transaction and close it on realm close (#3164) Add more detailed unsupported type error (#3163) Build Xamarin.Android tests in all ABIs (#3165) # Conflicts: # Tests/Realm.Tests/Generated/Realm.SourceGenerator/Realms.SourceGenerator.RealmGenerator/ObjectWithPartitionValue_generated.cs
Description
Replaces #3121. Putting up a different PR to make sure I don't accidentally overlook something.
TODO