Move the SG and weaver binaries to the Realm package #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4947962804
💛 - Coveralls |
papafe
approved these changes
May 11, 2023
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ItemGroup Label="Package"> |
There was a problem hiding this comment.
Is this label used anywhere, or is it here just for readability?
There was a problem hiding this comment.
Yeah, just for readability - if you collapse all nodes, you get several ItemGroup sections with no indication what is for what, so figured I'd add a label to clarify things a little.
fealebenpae
approved these changes
May 11, 2023
nirinchev
changed the title
nirinchev
added a commit
that referenced
this pull request
Jun 12, 2023
* main: (29 commits) Add platform-specific helpers package (#3323) Allow geobox to be constructed from 4 coordinates (#3341) Add support for geospatial queries (#3300) Update UWP certificate, add instructions on how to do it (#3338) Don't throw an exception when setting an embedded property to the same value (#3337) Automatically handle object -> embedded object migrations (#3322) Add a check for the thread in Realm.IsInTransaction (#3336) Update to latest Core (#3334) Fix a few typos Move the SG and weaver binaries to the Realm package (#3319) Update ci-actions to latest commit (#3318) Fix a couple of warnings (#3317) Prepare for vNext (#3316) Prepare for 11.0.0 (#3315) Add support for arm on Linux (#3267) Update changelog Add tests for Set.PropertyChanged notifications (#3309) Change testing targets to net7.0 (#3305) Adjust codeql config (#3311) Allow publishing unity package on prerelease workflow (#3310) ... # Conflicts: # Realm/Realm.UnityWeaver/UnityWeaver.cs # wrappers/realm-core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the Realm.SourceGenerator package and moves the analyzer inside the regular Realm package. This should have no functional impact, but is a slight improvement in terms of maintainability as we have one fewer package to manage. It also makes it easier for users to understand what our dependencies are.
TODO