Remove log files in Realm.deleteRealm #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@finnschiermer Please review. |
|
👍 @finnschiermer Please see if we have overlooked some aux. files. |
|
After a brief chat with @finnschiermer, it is safer to remove all files in the |
|
👍 |
| @@ -1922,14 +1911,15 @@ public void run() { | |||
| realm.beginTransaction(); | |||
| realm.createObject(AllTypes.class); | |||
| realm.commitTransaction(); | |||
| // Move the directory so core won't be able to delete log files | |||
There was a problem hiding this comment.
Instead describe why it could happen, i.e during an upgrade of Realm where core changed the location of log files.
|
Apart from minor comment 👍 |
| new File(rootFolder, realmFileName + ".log_a"), | ||
| new File(rootFolder, realmFileName + ".log_b"), | ||
| new File(rootFolder, realmFileName + ".log"), | ||
| // New styles |
There was a problem hiding this comment.
Those four lines can be removed.
|
👍 |
| // there is no subfolders in the management folder | ||
| File[] files = managementFolder.listFiles(); | ||
| if (files != null) { | ||
| for (File file : files) { |
There was a problem hiding this comment.
Nitpick, but use a simple for loop instead to save the allocation of an iterator.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2834