Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for RN >= 0.49 metro-bundler check for single string liter… #1346

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

ashwinphatak
Copy link
Contributor

@ashwinphatak ashwinphatak commented Sep 26, 2017

…al argument to require() (#1342)

What, How & Why?

Reference to the issue(s) addressed by this PR: # ???

☑️ ToDos

  • 📝 Changelog entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@ashwinphatak ashwinphatak merged commit c550105 into master Sep 26, 2017
@ashwinphatak ashwinphatak deleted the ap/rn49_bundler_fix branch September 26, 2017 07:48
@blagoev
Copy link
Contributor

blagoev commented Sep 26, 2017

although this fixes the issue. The #1332 got a point that we should not be fighting the RN but working with it. These workarounds and node requires work but maybe it's worth investigating how we can remove them since they are workarounds still.

@ashwinphatak got a good point that #1332 may introduce a breaking change, but isn't it worth investigating how we can have #1332 in and not introducing the breaking change at the same time.

in short this fix just fixes the workaround

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants