Xcode 9 fixes #1483
Merged
Xcode 9 fixes #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blagoev
reviewed
Nov 17, 2017
| shellScript = "node ../scripts/download-realm.js ios --sync"; | ||
| showEnvVarsInLog = 0; | ||
| shellPath = "/bin/sh"; | ||
| shellScript = "[ -z \"$NVM_DIR\" ] && export NVM_DIR=\"$HOME/.nvm\"\n\nif [[ -s \"$HOME/.nvm/nvm.sh\" ]]; then\n . \"$HOME/.nvm/nvm.sh\"\nelif [[ -x \"$(command -v brew)\" && -s \"$(brew --prefix nvm)/nvm.sh\" ]]; then\n . \"$(brew --prefix nvm)/nvm.sh\"\nfi\nnode ../scripts/download-realm.js ios --sync"; |
There was a problem hiding this comment.
this will probably fail on CI
There was a problem hiding this comment.
it failed last time I committed it.
Closed
This was referenced Nov 23, 2017
Closed
…n tests immediatelly and exit afterwards
# Conflicts: # tests/js/list-tests.js # tests/js/results-tests.js
bdash
reviewed
Dec 13, 2017
| render() { | ||
| // let objects = realm.objects('Todo'); | ||
| // let extraItems = [ | ||
| // { name: 'Complete', items: objects.filtered('done = true') }, |
There was a problem hiding this comment.
Is there a reason we're adding a bunch of commented-out code (here, and elsewhere)?
There was a problem hiding this comment.
no this is leftover. will remove
kneth
commented
Dec 14, 2017
| @@ -0,0 +1,63 @@ | |||
| //////////////////////////////////////////////////////////////////////////// | |||
| // | |||
| // Copyright 2016 Realm Inc. | |||
| Platform, | ||
| StyleSheet | ||
| } from 'react-native'; | ||
| // import NavigationExperimental from 'react-native-deprecated-custom-components'; |
There was a problem hiding this comment.
Can be removed (and line 27 too)
| import realm from './realm'; | ||
| import styles from './styles'; | ||
|
|
||
| export default class TodoApp extends React.Component { | ||
| // import NavigationExperimental from 'react-native-deprecated-custom-components'; |
| }); | ||
| } | ||
| this.todoLists.addListener((name, changes) => { | ||
| console.log("changed: " + JSON.stringify(changes)); | ||
| if (params) { | ||
| console.error("params.json indicate a test run. Exiting application"); |
There was a problem hiding this comment.
"indicate" -> "indicates"
| }); | ||
| console.log("registered listener"); | ||
|
|
||
|
|
||
| // Bind all the methods that we will be passing as props. | ||
| this.renderScene = this.renderScene.bind(this); | ||
| // this.renderScene = this.renderScene.bind(this); |
scripts/test.sh
Outdated
| : # nothing to see here, will stop cycling on the first successful run | ||
| done | ||
| #parse devices | ||
| IOS_RUNTIME=$(xcrun simctl list runtimes | grep -m1 -o '(com.apple.CoreSimulator.SimRuntime.iOS.*)' | sed 's/[()]//g') |
There was a problem hiding this comment.
It doesn't work for me locally. Doing xcrun simctl list runtimes | grep -m1 'com.apple.CoreSimulator.SimRuntime.iOS.*' | awk '{ print $2 }', gets the iOS version number for me locally. When running ./scripts/test.sh react-tests I see the following in the end:
Shuttting down realm-js-test simulator. (device is not deleted. you can use it to debug the app)
Checking tests results
*** ReactTests SUCCESS ***
| import RNFS from 'react-native-fs'; | ||
| import RNExitApp from 'react-native-exit-app-no-history'; | ||
|
|
||
| // import {setJSExceptionHandler} from 'react-native-exception-handler'; |
There was a problem hiding this comment.
Can this section be removed?
address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We have seen many issue related to Xcode recently. The number of issues increased when Xcode 9 was released but it is still unclear if all the issues are related to that version.
TODO
nodeinside Xcode must match version used when executingnpm installReact/RCTBridge.hnot found)libReact.anot found)'sendAppEventWithName:body:' is deprecated: Subclass RCTEventEmitter instead)CHANGELOG.mdStatus