Add tests of support types of partition values #3671
Conversation
| docker run $DOCKER_VOLUMES -p 9090:9090 -it "docker.pkg.github.com/realm/ci/mongodb-realm-test-server:${MDBREALM_TEST_SERVER_TAG}" | ||
| else | ||
| STITCH_DOCKER_ID=$(docker run -d $BACKGROUND_FLAG -v "${SRCROOT}/tests/mongodb:/apps/os-integration-tests" -p 9090:9090 -it "docker.pkg.github.com/realm/ci/mongodb-realm-test-server:${MDBREALM_TEST_SERVER_TAG}") | ||
| STITCH_DOCKER_ID=$(docker run -d $BACKGROUND_FLAG $DOCKER_VOLUMES -p 9090:9090 -it "docker.pkg.github.com/realm/ci/mongodb-realm-test-server:${MDBREALM_TEST_SERVER_TAG}") |
There was a problem hiding this comment.
[Suggestion] I'd actually really like it if we can introduce an env variable that changes the local port we forward to the Docker image (e.g., MONGODB_REALM_PORT=9091).
makeAppConfig() seems to support this already using process.env.MONGODB_REALM_PORT.
There was a problem hiding this comment.
I support the suggestion, but for testing on iOS/Android the task becomes less trivial, as the port would have to be passed to the test-app & Android need to have the port reversed. So I think out of scope, just now.
There was a problem hiding this comment.
There's other places in the script files that we provide a default if the environment variable isn't set, though.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "app_id": "pv-int-tests-lmuyx", | |||
There was a problem hiding this comment.
[Question] Is it safe to hard-code App IDs? Aren't they randomly generated when Docker starts the image?
There was a problem hiding this comment.
These ids are overridden on each run (I think we're awaiting an update, where this won't happen).
I think we should see this solution as temporary.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "app_id": "pv-objectid-tests-zedts", | |||
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "app_id": "pv-string-tests-bfnat", | |||
There was a problem hiding this comment.
[Question} Flagging app_id, just in case.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "app_id": "pv-uuid-tests-axhms", | |||
|
Moved to #3677 |
Adding MongoDB Realm apps for each support type of partition value.
The tests should be refactored to avoid code duplication.