Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable executable stack on Linux #3775

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Disable executable stack on Linux #3775

merged 3 commits into from
Jun 9, 2021

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jun 2, 2021

What, How & Why?

This closes #3752

We will have to prebuild OpenSSL with the same options.

☑️ ToDos

  • 📝 Changelog entry
  • [ ] 📝 Compatibility label is updated or copied from previous entry
  • [ ] 🚦 Tests
  • [ ] 📝 Public documentation PR created or is not necessary
  • [ ] 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • [ ] typescript definitions file is updated
  • [ ] jsdoc files updated
  • [ ] Chrome debug API is updated if API is available on React Native

@kneth kneth self-assigned this Jun 2, 2021
CMakeLists.txt Outdated Show resolved Hide resolved
Co-authored-by: Andrew Meyer <[email protected]>
@kneth kneth marked this pull request as ready for review June 8, 2021 15:37
@kneth kneth requested review from RedBeard0531 and fronck June 8, 2021 15:37
Copy link

@fronck fronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kneth kneth merged commit 9ae4043 into master Jun 9, 2021
@kneth kneth deleted the kneth/no-execstack branch June 9, 2021 14:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROT_EXEC to mmap(2) during mediation which may cause security denials
3 participants