Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dangling c_str() #3791

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix dangling c_str() #3791

merged 1 commit into from
Jun 8, 2021

Conversation

RedBeard0531
Copy link
Contributor

What, How & Why?

Saw a compiler warning about this, and it is a real bug, not a false positive.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@RedBeard0531 RedBeard0531 requested review from kneth and kraenhansen June 7, 2021 13:42
@RedBeard0531 RedBeard0531 merged commit 5d46a29 into master Jun 8, 2021
@RedBeard0531 RedBeard0531 deleted the ms/dangling branch June 8, 2021 08:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants