Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible with Kotlin 2.1.0 #1860

Open
wants to merge 6 commits into
base: community
Choose a base branch
from
Open

Conversation

XilinJia
Copy link

There are a few changes in this PR:

  1. added a build script for Linux
  2. updated related Kotlin code to work with Kotlin 2.1.0
  3. changed project structure to make Intellij IDE work, buildSrc is moved out of scope io.realm, gradlew now should be run in the root directory rather than in packages
  4. amended Contributing.md to reflect the structure changes
  5. updated most dependencies

Facts:

  1. I've only tested the project on Linux but kept the project open for over two weeks to let others test it in various conditions.
  2. as it stand, testing can be run on dev versions not on maven artifacts.
  3. tests run resulting 4 failures with Kotlin 2.1.0 that also occurred with Kotlin 2.0.x before any modifications were made. documented here: 4 failed tests related to BacklinksTests XilinJia/realm-kotlin#1 (comment).

Copy link

cla-bot bot commented Feb 12, 2025

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @XilinJia. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@XilinJia
Copy link
Author

is CLA still needed for the community branch?

@MrJohn10
Copy link

@clementetb Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants