Call mypy with newly added parameter flush_errors
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's only the Python 3.3 that failed. Given that mypy itself now needs at least Python 3.4 to run, it seems that can be safely removed actually from Travis setup and other places. I will submit another commit for that. |
Unfortunately the target function does not have any docstring in mypy, but it is typed as Optional[] which means the function should accept None as a value. Doing so seems to suppress issues reported in realpython#6. Quick skim of the culprit PR in mypy (https://github.com/python/mypy/pull/4396/files) shows the code really counts with None being passed and adjusting appropriately, citing: > If we were not given a flush_errors, we use one that will populate > those fields for callers that want the traditional API.
Mypy itself needs Python 3.4 at least, citing it's README.md: > You need Python 3.4 or later to run mypy
petr-muller
force-pushed
the
flush-errors
branch
from
1cac7ca to
71f9137
Compare
macheins
approved these changes
Mar 6, 2018
|
Please please please can we get this merged and released ASAP? |
jniedrauer
approved these changes
Mar 7, 2018
Merged
|
👍 |
|
LGTM, thanks guys. I'm so swamped right now with other stuff—anybody interested in becoming a collaborator on this repo and helping out with maintaining this thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the target function does not have any docstring in mypy,
but it is typed as Optional[] which means the function should accept
None as a value. Doing so seems to suppress issues reported in #6.
Quick skim of the culprit PR in mypy
(https://github.com/python/mypy/pull/4396/files) shows the code really
counts with None being passed and adjusting appropriately, citing: