config: add k8s default namespace #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
reana_commons/config.py
Outdated
| @@ -133,3 +133,5 @@ | |||
|
|
|||
| REANA_WORKFLOW_UMASK = 0o0002 | |||
| """Umask used for workflow worksapce.""" | |||
|
|
|||
| K8S_DEFAULT_NAMESPACE = "DEFAULT" | |||
There was a problem hiding this comment.
We should probably add a docstring explaining what it is and maybe even renaming the variable so we state clearly that this namespace is the namespace where all REANA Workflow Engines and Kubernetes jobs are going to be spawned in.
To help with the naming, this is closely related to Tibor's reanahub/reana-job-controller#71 (comment), where he makes reference to the five compute layers of the REANA platform and this variable would affect layer 2, so something like K8S_WORKFLOW_RUNTIME_DEFAULT_NAMESPACE, what do you think?:)
roksys
force-pushed
the
job-class-abstraction
branch
2 times, most recently
from
b8d10ef to
5d908a2
Compare
* Add config var for default K8s job namesapce. API changes for multiple job bakend support. Connects reanahub/reana-job-controller/issues/118 Signed-off-by: Rokas Maciulaitis <[email protected]>
roksys
force-pushed
the
job-class-abstraction
branch
from
5d908a2 to
a5c30c0
Compare
diegodelemos
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config+api: add k8s default namespace & multiple job backends support
job bakend support.
Connects multiple job backend support reana-job-controller#118
Signed-off-by: Rokas Maciulaitis [email protected]