-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs: adding job class #117
Conversation
9407aa5
to
3eee834
Compare
reana_job_controller/job.py
Outdated
return result | ||
return wrapper | ||
|
||
def before_submission(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/submission/execution/g
everywhere? Seems more natural to take the r-j-controller's internal point of view and talk about executing jobs that were "already submitted" to it by the r-w-engine. E.g. thinking of k8s or docker execution scenarios irst. For HPC/HTC scenarios, the jobs will be sent (i.e. submitted) elsewhere indeed, so e.g. from SLURM's point of view there will be another submission, however from the r-j-c's internal point of view this is just a way of executing the jobs it was asked to run; the r-j-c will just select to proxy them to another backend. (In other words, a "primary submission" is happening between r-w-e and r-j-c, and it is only a "secondary submission" that is happening between r-j-c and SLURM for some backends, so to speak.) Hence my preference for speaking about executing rather then submitting jobs inside r-j-c in general.
1ffee4e
to
ad6e794
Compare
* jobManager super class is responsible for job creation, execution/submission, deletion/stop and etc. Thic class should be inherited by child classes of specific backend (K8s, HTCondor, Slurm and etc.) Signed-off-by: Rokas Maciulaitis <[email protected]>
8cdc3a1
to
5baa2e0
Compare
return wrapper | ||
|
||
def before_execution(self): | ||
"""Before job submission hook.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that @lukasheinrich was trying out git-base syncing of needed input/output files instead of rsync-based syncing
1467251
to
9ec8795
Compare
Works locally and looks good 👍 we just need to make Travis happy, polish a couple of things and create issues for what needs to be done after: For now:
For later, to translate into issues:
|
6c52d82
to
0d21b8d
Compare
0d21b8d
to
cb9d4d0
Compare
execution/submission, deletion/stop and etc. Thic class
should be inherited by child classes of specific backend
(K8s, HTCondor, Slurm and etc.) Closes multiple job backend support #118
Co-authored-by: Diego Rodriguez Rodriguez [email protected]
Signed-off-by: Rokas Maciulaitis [email protected]