global: sets compute backend from docker build arg. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roksys
force-pushed
the
set-build-args
branch
2 times, most recently
from
402f100 to
c904834
Compare
reana_job_controller/job_manager.py
Outdated
| @@ -130,3 +133,10 @@ def cache_job(self): | |||
| def update_job_status(self): | |||
| """Update job status in DB.""" | |||
| pass | |||
|
|
|||
| def _extend_env_vars(self, env_vars): | |||
There was a problem hiding this comment.
What is the use case for this?
What do you think about returning just the REANA specific variables (then maybe changing the name of the function to something like _get_reana_env_variables) and then when we use it we explicitly extend the user-provided env vars with the REANA ones?
Updated
I see this comes from a different PR! #176
diegodelemos
approved these changes
Aug 14, 2019
roksys
force-pushed
the
set-build-args
branch
2 times, most recently
from
3f4c984 to
f1e8f6b
Compare
* Closes reanahub#170 Signed-off-by: Rokas Maciulaitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global: sets compute backend from docker build arg.