workflow_run_manager: renames HTCONDORCERN_USERNAME to CERN_USERNAME #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roksys
commented
Dec 3, 2019
roksys
commented
- Addresses Launch jobs on HPC (SLURM) reana-job-controller#71
roksys
force-pushed
the
rename-htcondor-user
branch
from
cc26f43 to
11bdde7
Compare
tiborsimko
reviewed
Dec 3, 2019
| @@ -357,7 +357,7 @@ def _create_job_spec(self, name, command=None, image=None, | |||
| get_env_secrets_as_k8s_spec() | |||
|
|
|||
| user = \ | |||
| secrets_store.get_secret_value('HTCONDORCERN_USERNAME') or \ | |||
| secrets_store.get_secret_value('CERN_USER') or \ | |||
There was a problem hiding this comment.
Please amend the commit log message to say CERN_USER also there... otherwise people could misunderstand...
* Renames HTCONDORCERN_USERNAME,CERN_USERNAME to CERN_USER Addresses reanahub/reana-job-controller#71
roksys
force-pushed
the
rename-htcondor-user
branch
from
11bdde7 to
3f6d3aa
Compare
tiborsimko
approved these changes
Dec 4, 2019
diegodelemos
pushed a commit
to diegodelemos/reana-workflow-controller
that referenced
this pull request
Jun 11, 2020
* Creates REANA runtime objects in the configured runtime namespace. Note that if no runtime namespace is configured by default it will be the same as the infrastructure pods namespace (closes reanahub#268).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.