-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(master): merge maint-0.9 #590
Conversation
tiborsimko
commented
Jun 26, 2024
- feat(helm): allow cluster administrator to configure ingress host (feat(helm): allow cluster administrator to configure ingress host (#588) #588)
- ci(commitlint): improve checking of merge commits (chore(master): merge maint-0.9 #590)
* feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 73.39% 73.57% +0.17%
==========================================
Files 15 15
Lines 1372 1385 +13
==========================================
+ Hits 1007 1019 +12
- Misses 365 366 +1
|
feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the PR to also include this missing commit? 784efee
Regarding instead the changes to commitlint, could you also add the other changes to ci.yml
from this commit? reanahub/reana-workflow-engine-snakemake@690dfc2
feat(sessions): expose user secrets in interactive sessions (reanahub#591) feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!