Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): merge maint-0.9 #590

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

tiborsimko
Copy link
Member

tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Jun 26, 2024
* feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.57%. Comparing base (13d1c5d) to head (f1764ed).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
reana_workflow_controller/k8s.py 85.00% 3 Missing ⚠️
...eana_workflow_controller/rest/workflows_session.py 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   73.39%   73.57%   +0.17%     
==========================================
  Files          15       15              
  Lines        1372     1385      +13     
==========================================
+ Hits         1007     1019      +12     
- Misses        365      366       +1     
Files with missing lines Coverage Δ
reana_workflow_controller/config.py 100.00% <100.00%> (ø)
reana_workflow_controller/workflow_run_manager.py 79.80% <100.00%> (+0.09%) ⬆️
reana_workflow_controller/k8s.py 88.88% <85.00%> (+0.75%) ⬆️
...eana_workflow_controller/rest/workflows_session.py 72.34% <75.00%> (-0.39%) ⬇️

tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Jun 26, 2024
feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the PR to also include this missing commit? 784efee

Regarding instead the changes to commitlint, could you also add the other changes to ci.yml from this commit? reanahub/reana-workflow-engine-snakemake@690dfc2

feat(sessions): expose user secrets in interactive sessions (reanahub#591)
feat(helm): allow cluster administrator to configure ingress host (reanahub#588)
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tiborsimko tiborsimko merged commit f1764ed into reanahub:master Jul 3, 2024
14 checks passed
@tiborsimko tiborsimko deleted the merge branch July 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants