Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(master): merge maint-0.9 #622

Merged
merged 9 commits into from
Jan 15, 2025
Merged

chore(master): merge maint-0.9 #622

merged 9 commits into from
Jan 15, 2025

Conversation

tiborsimko
Copy link
Member

mdonadoni and others added 8 commits July 3, 2024 12:22
@mdonadoni
fix(set_workflow_status): validate endpoint arguments (reanahub#589)
5945d7f 
Closes reanahub/reana-client#718
@tiborsimko
build(docker): pin setuptools 70 (reanahub#601)
be6a388 
Pin `setuptools` to the maximum version of 70 to allow working on Ubuntu
20.04 LTS based environments. (New versions of `setuptools` are not
compatible.)

Note that this fix is necessary only for the `maint-0.9` branches and
the REANA 0.9 release series. In `master` we have switched to Ubuntu
24.04 LTS based environments and Python 3.12 and no pinning is necessary
there.
@tiborsimko
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
72f0c4c
@mdonadoni
fix(config): read secret key from env (reanahub#615)
7df1279 
Make sure the secret key is propagated to the Flask app, instead of
incorrectly using the default one.
@mdonadoni
fix(manager): pass RabbitMQ connection details to workflow engine (re…
cf4ee73 
…anahub#615)

Make sure that workflow engines are able to connect to RabbitMQ to be
able to publish workflow status update messages.
@wirespecter @mdonadoni
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub…
24563e5 
…#615)

Configure the security context of workflow orchestrator jobs to disallow
privilege escalation.
@mdonadoni
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620
179fa89 
)
@github-actions @mdonadoni
chore(maint-0.9): release 0.9.4
050b4e6
tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Dec 3, 2024
@tiborsimko
chore(master): merge maint-0.9 (reanahub#622)
4cc6682 
chore(maint-0.9): release 0.9.4 (reanahub#556)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620)
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub#615)
fix(manager): pass RabbitMQ connection details to workflow engine (reanahub#615)
fix(config): read secret key from env (reanahub#615)
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
build(docker): pin setuptools 70 (reanahub#601)
fix(set_workflow_status): validate endpoint arguments (reanahub#589)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Dec 3, 2024
@tiborsimko
chore(master): merge maint-0.9 (reanahub#622)
47b799d 
chore(maint-0.9): release 0.9.4 (reanahub#556)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620)
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub#615)
fix(manager): pass RabbitMQ connection details to workflow engine (reanahub#615)
fix(config): read secret key from env (reanahub#615)
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
build(docker): pin setuptools 70 (reanahub#601)
fix(set_workflow_status): validate endpoint arguments (reanahub#589)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
@tiborsimko tiborsimko self-assigned this Dec 16, 2024
Alputer
Alputer approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Alputer Alputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Jan 15, 2025
@tiborsimko
chore(master): merge maint-0.9 (reanahub#622)
ad98b12 
chore(maint-0.9): release 0.9.4 (reanahub#556)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620)
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub#615)
fix(manager): pass RabbitMQ connection details to workflow engine (reanahub#615)
fix(config): read secret key from env (reanahub#615)
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
build(docker): pin setuptools 70 (reanahub#601)
fix(set_workflow_status): validate endpoint arguments (reanahub#589)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
tiborsimko added a commit to tiborsimko/reana-workflow-controller that referenced this pull request Jan 15, 2025
@tiborsimko
chore(master): merge maint-0.9 (reanahub#622)
4f4771f 
chore(maint-0.9): release 0.9.4 (reanahub#556)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620)
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub#615)
fix(manager): pass RabbitMQ connection details to workflow engine (reanahub#615)
fix(config): read secret key from env (reanahub#615)
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
build(docker): pin setuptools 70 (reanahub#601)
fix(set_workflow_status): validate endpoint arguments (reanahub#589)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
@tiborsimko
chore(master): merge maint-0.9 (reanahub#622)
4b0b2ff 
chore(maint-0.9): release 0.9.4 (reanahub#556)
build(python): bump shared REANA packages as of 2024-11-28 (reanahub#620)
fix(manager): avoid privilege escalation in Kubernetes jobs (reanahub#615)
fix(manager): pass RabbitMQ connection details to workflow engine (reanahub#615)
fix(config): read secret key from env (reanahub#615)
feat(config): upgrade to Jupyter SciPy 7.2.2 notebook (reanahub#614)
build(docker): pin setuptools 70 (reanahub#601)
fix(set_workflow_status): validate endpoint arguments (reanahub#589)

Note: The merge commit removes the changes related to pinning
`setuptools` to version 70, because this was only necessary for the
`maint-0.9` branches, as well as other 0.9.4 release-related changes.
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.59%. Comparing base (7896c61) to head (4b0b2ff).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
reana_workflow_controller/rest/utils.py 60.00% 2 Missing ⚠️
reana_workflow_controller/rest/workflows_status.py 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   76.61%   76.59%   -0.02%     
==========================================
  Files          17       17              
  Lines        1847     1846       -1     
==========================================
- Hits         1415     1414       -1     
  Misses        432      432
Files with missing lines Coverage Δ
reana_workflow_controller/config.py 94.03% <100.00%> (+0.08%) ⬆️
reana_workflow_controller/factory.py 100.00% <ø> (ø)
reana_workflow_controller/k8s.py 83.82% <100.00%> (ø)
reana_workflow_controller/version.py 100.00% <ø> (ø)
reana_workflow_controller/workflow_run_manager.py 80.67% <ø> (ø)
reana_workflow_controller/rest/utils.py 82.59% <60.00%> (+0.19%) ⬆️
reana_workflow_controller/rest/workflows_status.py 82.55% <80.00%> (-1.17%) ⬇️

@tiborsimko tiborsimko merged commit 4b0b2ff into reanahub:master Jan 15, 2025
14 checks passed
@tiborsimko tiborsimko deleted the merge branch January 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alputer Alputer Alputer approved these changes

Assignees

@tiborsimko tiborsimko

Labels
None yet
Projects
0.95.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiborsimko @Alputer @mdonadoni @wirespecter