-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kind multinode opt mount #344
Kind multinode opt mount #344
Conversation
1b1d675
to
3c8484e
Compare
3c8484e
to
6045c33
Compare
47d54e1
to
7b0e938
Compare
reana/cli.py
Outdated
@@ -1687,15 +1780,16 @@ def cluster_undeploy(): # noqa: D301 | |||
help="Destroy and recreate cluster from scratch?", | |||
) | |||
@cli.command(name="run-ci") | |||
def run_ci(mount, recreate): # noqa: D301 | |||
def run_ci(mounts, recreate): # noqa: D301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the mount options are only used during cluster creation time, one cannot easily change mount? do-not-mount? decision once the cluster is created. So perhaps we can move the recreate command to cluster-create so that we don't have to duplicate all these arguments?
This would mean people will have to do:
$ reana-dev cluster-create
$ reana-dev run-ci
$ reana-dev cluster-delete
manually.
If it seems OK, then we should do:
- enrich
cluster-create
so that it does docker-pulling and kind-load-docker-image steps after cluster creation; - leave out cluster-delete step, people will have to do it manually
- remove mount, recreate option from run-ci, because there were consumed already
- enrich run-ci options with --debug flag so that docker images would be built with DEBUG flag
0dcdf0b
to
e246987
Compare
79cf7e3
to
3f3fbc6
Compare
3f3fbc6
to
e10f582
Compare
* Enables mounting custom paths into job pods.
e10f582
to
d17b34f
Compare
No description provided.