Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pprint ast #1799

Merged
merged 11 commits into from
Jan 31, 2018
Merged

Cleanup pprint ast #1799

merged 11 commits into from
Jan 31, 2018

Conversation

let-def
Copy link
Contributor

@let-def let-def commented Jan 31, 2018

Extract comments and layout related code from Reason_pprint_ast to Reason_comment and Reason_layout modules.
Remove dead code from Reason_pprint_ast.

@chenglou
Copy link
Member

cc @IwanKaramazow

@let-def let-def mentioned this pull request Jan 31, 2018
Open
jordwalke
jordwalke reviewed Jan 31, 2018
View reviewed changes
src/reason-parser/reason_pprint_ast.ml
| (Lapply (l11, l12), Lapply (l21, l22)) ->
longIdentSame (l11, l21) && longIdentSame (l12, l22)
| _ -> false
let string_equal : string -> string -> bool = (=)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jordwalke jordwalke merged commit f8e78c3 into reasonml:master Jan 31, 2018
@jordwalke
Copy link
Member

Thanks, @let-def !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordwalke jordwalke jordwalke left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@let-def @chenglou @jordwalke @facebook-github-bot