-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docusaurus to 1.3.1 #398
Conversation
Not really, thanks for pointing it out.
Will fix that!
Will fix that!
Got it. I think with the new styling the code border looks better without extending beyond the content.
Yay!
That has been annoying me for a while. Glad that it's fixed now.
Yep I think it's more professional for documentation websites to have black headings. I referenced a ton of existing documentation sites and they all have neutral color headings. Users could easily override this if they wanted, so feel free 😄 I'll address the above-mentioned CSS issues in Docusaurus and we'll release a 1.3.1 and I'll update this PR with 1.3.1. Thanks for the thorough review! |
Ok we released Docusaurus 1.3.1 and I updated this PR with that Docusaurus version! |
Thanks so much =) |
Summary
Docusaurus 1.3.1 brings about some backwards-incompatible CSS changes. So the team is helping the major users update 😄
I removed some custom CSS pertaining to the side nav as the fixed nav is now part of Docusaurus core. Also changed the code blocks in table markup and standardized them across the site.
cc @JoelMarcey @endiliey
Test plan
Ran the site locally and visited every page.