Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance on large SQL/graphs #685

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rubytobi
Copy link
Contributor

@rubytobi rubytobi commented Feb 8, 2025

As discussed in #679, I've done a first draft of minimal changes to speed up the column level lineage identification.

I think we should keep networkx - it's more powerful and flexible - and just switch to rustworkx where needed for performance reason.

Keen to hear your thoughts!

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (10b7445) to head (2db8769).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          41       41           
  Lines        2244     2253    +9     
=======================================
+ Hits         2234     2243    +9     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@reata reata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a performance test to show that rustworkx can handle large graph within certain time compared to networkx?

Also if we're converting networkx graph to rustworkx, then I don't think adding a graph property is needed. You can directly make a copy from self._sql_holder.graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants