What does it mean when hsl is None in the callbacks?

[rec]

Example here.

Is this a callback from outside the sphere?

Perhaps this is actually a different kind of callback, then?

[Anders-Holst]

Yes, when you leave the sphere, there is no color under the pointer, and hsl is set to None accordingly. The same holds for the click callback. Originally, the callback was not called at all when the pointer was outside of the sphere. However, I wanted it to do things when leaving the sphere (specifically, leaving rt mode by returning to the previous mode or the last set color), and the easiest way was to remove the check on hsl previously done before the callback, and add it inside the callback instead.

[Anders-Holst]

Aha, what you suggest is to add a new callback which is called when leaving/entering the sphere. Yea one can do that. Build an entire event system with lots of event handlers if one likes it... I tried to keep it simple and straightforward, but agree that it is at the cost of overloading this callback to mean different things.

[rec]

This on_click(hsl, event) on_move(hsl, event) on_enter(event) on_exit(event) vs this on_click(hsl, event) # hsl == None means ? on_move(hsl, event) # hsl == None means ? !

…

On Sat, Oct 16, 2021 at 5:06 PM Anders-Holst ***@***.***> wrote: Aha, what you suggest is to add a new callback which is called when leaving/entering the sphere. Yea one can do that. Build an entire event system with lots of event handlers if one likes it... I tried to keep it simple and straightforward, but agree that it is at the cost of overloading this callback to mean different things. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB53MUT6KX53CMEY3ROF5LUHGIHRANCNFSM5GDSTUJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- /t PGP Key: ***@***.*** *https://tom.ritchford.com <https://tom.ritchford.com>* *https://tom.swirly.com <https://tom.swirly.com>*