PluginManager: capitalize folder and rename constant #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugins directory already creates in the capital version of the folder, just rename it to be capital here for consistency, and to be consistent with the name of the app
fire-light42
requested changes
Dec 31, 2024
| private val CLOUD_STREAM_FOLDER = | ||
| Environment.getExternalStorageDirectory().absolutePath + "/Cloudstream3/" | ||
| private val CLOUDSTREAM3_FOLDER = | ||
| Environment.getExternalStorageDirectory().absolutePath + "/CloudStream3/" |
There was a problem hiding this comment.
"Linux file system treats file and directory names as case-sensitive" so this will break all current plugins that are located in "Cloudstream3". Loop all folders that match Cloudstream3 in a case insensitive manner if you want to solve this.
|
I may do it later but for not I don't intend to put to much extra work into this minor change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugins directory already creates in the capital version of the folder, just rename it to be capital here for consistency, and to be consistent with the name of the app