Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Test benchmark utils #1832

Closed
miguelgfierro opened this issue Oct 20, 2022 · 7 comments
Closed

[FEATURE] Test benchmark utils #1832

miguelgfierro opened this issue Oct 20, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@miguelgfierro
Copy link
Collaborator

miguelgfierro commented Oct 20, 2022 •
edited
Loading

Description

Related to #1831. We want to programmatically test the movielens benchmark

Expected behavior with the suggested feature

Other Comments

branch: miguel/bench_tests
@miguelgfierro miguelgfierro added the enhancement New feature or request label Oct 20, 2022
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Oct 20, 2022 •
edited
Loading

Make sure that each of them can run in an independent env, not in the full one:

  • pytest tests/integration/examples/test_notebooks_python.py::test_benchmark_movielens_cpu --disable-warnings
  • pytest tests/integration/examples/test_notebooks_pyspark.py::test_benchmark_movielens_pyspark --disable-warnings
  • pytest tests/integration/examples/test_notebooks_gpu.py::test_benchmark_movielens_gpu --disable-warnings

Grab the metrics and make sure they are correct:

  • CPU
  • PySpark
  • GPU

@miguelgfierro

This comment was marked as resolved.

Sign in to view
@prateekiiest
Copy link

prateekiiest commented Oct 24, 2022 •
edited
Loading

relative import error?

Facing the same issue while trying to run the dataset evaluations on Jupyter Notebook

@miguelgfierro

This comment was marked as resolved.

Sign in to view
@miguelgfierro

This comment was marked as resolved.

Sign in to view
@miguelgfierro

This comment was marked as resolved.

Sign in to view
@miguelgfierro

This comment was marked as resolved.

Sign in to view
miguelgfierro added a commit that referenced this issue Nov 11, 2022
@miguelgfierro
wip #1832
4ffbb16
miguelgfierro added a commit that referenced this issue Nov 11, 2022
@miguelgfierro
fix #1832
6a99603
@miguelgfierro miguelgfierro mentioned this issue Nov 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelgfierro @prateekiiest