-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename folders #1478
Rename folders #1478
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
examples/02_model_collaborative_filtering/cornac_bpr_deep_dive.ipynb
Outdated
Show resolved
Hide resolved
examples/02_model_collaborative_filtering/cornac_bpr_deep_dive.ipynb
Outdated
Show resolved
Hide resolved
examples/02_model_collaborative_filtering/lightgcn_deep_dive.ipynb
Outdated
Show resolved
Hide resolved
This work will trigger a new major version, correct? @miguelgfierro |
Wrong renames:
Etc. Maybe they cancel out. Good to double check whether all the empty init files are there. |
about this @anargyri:
I think the changes are ok, when I did git mv, I think git can't assign between init files because they are the exact same empty file |
@wutaomsft we could do a new release if people want. Actually, now that we are changing paths, maybe we should consider other changes:
I'll start a chat on teams about this |
Description
Related Issues
#1390
Checklist:
staging branch
and not tomain branch
.