Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use pip install and venv #1509

Merged
merged 9 commits into from
Aug 31, 2021
Merged

Conversation

anargyri
Copy link
Collaborator

@anargyri anargyri commented Aug 26, 2021

Description

The docker container was not running properly and moreover it was using the script for generating a conda env.
In this PR, I modify the Dockerfile so that

  • dependencies are installed in the environment directly with pip
  • the docker container supports both conda and venv, which is selected by the user with a build argument
  • the README is accordingly updated.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@anargyri anargyri changed the title Andreas/docker Update Dockerfile to use pip install and venv Aug 26, 2021
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anargyri
Copy link
Collaborator Author

lgtm

I tested python 3.7 with conda and the numpy-base install.

@codecov-commenter
Copy link

Codecov Report

Merging #1509 (4a9063d) into staging (3e23511) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1509      +/-   ##
===========================================
- Coverage    61.96%   61.95%   -0.01%     
===========================================
  Files           84       84              
  Lines         8368     8369       +1     
===========================================
  Hits          5185     5185              
- Misses        3183     3184       +1     
Impacted Files Coverage Δ
recommenders/models/vae/standard_vae.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e23511...4a9063d. Read the comment docs.

@anargyri anargyri merged commit faaca49 into staging Aug 31, 2021
@anargyri anargyri deleted the andreas/docker branch August 31, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants