-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile to use pip install and venv #1509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I tested python 3.7 with conda and the numpy-base install. |
Codecov Report
@@ Coverage Diff @@
## staging #1509 +/- ##
===========================================
- Coverage 61.96% 61.95% -0.01%
===========================================
Files 84 84
Lines 8368 8369 +1
===========================================
Hits 5185 5185
- Misses 3183 3184 +1
Continue to review full report at Codecov.
|
Description
The docker container was not running properly and moreover it was using the script for generating a conda env.
In this PR, I modify the Dockerfile so that
Related Issues
Checklist:
staging branch
and not tomain branch
.