Staging to master for making release #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small change in SETUP
Move scikit-surprise and pymanopt from setup.py
Format the getting started section to make it clearer
miguelgfierro
requested review from
anargyri,
gramhagen,
loomlike and
wutaomsft
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
angusrtaylor
approved these changes
Jan 10, 2022
simonzhaoms
reviewed
Jan 11, 2022
| sudo apt-get install -y build-essential libpython<version> | ||
| ``` | ||
|
|
||
| where `<version>` should be `3.6` or `3.7` as appropriate. |
There was a problem hiding this comment.
Dose it support Python 3.8 now? To support Databricks 7.3+, Python 3.8 is required.
There was a problem hiding this comment.
"Programming Language :: Python :: 3.8", may also need to be added to:
https://github.com/microsoft/recommenders/blob/f4636b2e8e74d87233fd53958c5e0526674fc7f6/setup.py#L127-L134
There was a problem hiding this comment.
that's a good point, if my memory doesn't failed me, we had some problems with 3.8 and numpy? @anargyri might know more when he is back
There was a problem hiding this comment.
The unit tests work with Python 3.8. See #1617
simonzhaoms
reviewed
Jan 11, 2022
Issue with pymanopt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #1602 was fixed, merging to master for new release
Related Issues
Checklist:
staging branchand not tomain branch.