Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun LigthFM and add test #1706

Merged
merged 4 commits into from
May 4, 2022
Merged

Rerun LigthFM and add test #1706

merged 4 commits into from
May 4, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Added integration test to LightFM and rerun the notebook

Related Issues

Fix #1700

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@miguelgfierro miguelgfierro changed the base branch from main to staging April 21, 2022 12:00
@miguelgfierro miguelgfierro mentioned this pull request Apr 21, 2022
Closed
6 tasks
@miguelgfierro
Copy link
Collaborator Author

FYI @@fazamani

loomlike
loomlike approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@loomlike loomlike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miguelgfierro miguelgfierro merged commit 65d671e into staging May 4, 2022
@miguelgfierro miguelgfierro deleted the miguel/lightfm branch May 4, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri approved these changes

@loomlike loomlike loomlike approved these changes

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Review LigthFM notebook and do test
3 participants
@miguelgfierro @anargyri @loomlike