Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging to main, prepare for release 1.1.1 #1792

Merged
merged 38 commits into from
Jul 20, 2022
Merged

Staging to main, prepare for release 1.1.1 #1792

merged 38 commits into from
Jul 20, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro miguelgfierro requested a review from gramhagen as a code owner July 18, 2022 16:40
@miguelgfierro
Copy link
Collaborator Author

We need to figure out why the nightly builds are not triggered FYI @pradnyeshjoshi @simonzhaoms

@pradnyeshjoshi
Copy link
Collaborator

We need to figure out why the nightly builds are not triggered FYI @pradnyeshjoshi @simonzhaoms

@miguelgfierro currently nightly tests are triggered on push to staging or nightly from the main branch.

@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Jul 19, 2022

@miguelgfierro currently nightly tests are triggered on push to staging or nightly from the main branch.

@pradnyeshjoshi Let me clarify, what we are looking for is this:

  • 1. We want nightly builds in main scheduled every day (it seems we can't have them in staging)
  • 2. We want that the nightly builds are executed when there is a PR from staging to main (also the unit tests)
  • 3. We want the nightly builds to be executed in staging after the code is merged in staging, not in every push (this is not ideal, because what we really want is to execute the nightly in staging every night, but since it is not possible to schedule jobs there, this is better than executing staging every time there is a PR to it).

Now, the reasoning behind all this is because we are building a preprod/production system. In preprod (staging) is where we develop, and we test all the code and make sure that no errors are there, however, there might be errors, that's acceptable as long as they are not moved to main.

In main it is not acceptable to have errors, this is equivalent to having an error in production, it is a big mess. We monitor that main is healthy with the nightly builds every day, and also, before adding code to main (PR from staging to main) we execute all the tests (unit and nightly), because we don't want absolutely any error in main.

Does it make sense?

For visibility @fazamani @simonzhaoms

@pradnyeshjoshi
Copy link
Collaborator

@miguelgfierro 1 and 3 are already set up in the current code. I have created a PR for 2 here.

@pradnyeshjoshi pradnyeshjoshi self-requested a review July 20, 2022 00:32
@miguelgfierro miguelgfierro merged commit b704c42 into main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants