-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging to main, prepare for release 1.1.1 #1792
Conversation
Add composite actions to AzureML test workflows
We need to figure out why the nightly builds are not triggered FYI @pradnyeshjoshi @simonzhaoms |
@miguelgfierro currently nightly tests are triggered on push to staging or nightly from the main branch. |
@pradnyeshjoshi Let me clarify, what we are looking for is this:
Now, the reasoning behind all this is because we are building a preprod/production system. In preprod (staging) is where we develop, and we test all the code and make sure that no errors are there, however, there might be errors, that's acceptable as long as they are not moved to main. In main it is not acceptable to have errors, this is equivalent to having an error in production, it is a big mess. We monitor that main is healthy with the nightly builds every day, and also, before adding code to main (PR from staging to main) we execute all the tests (unit and nightly), because we don't want absolutely any error in main. Does it make sense? For visibility @fazamani @simonzhaoms |
…file-paths Add path filter for unit tests
Release notes Recommenders 1.1.1
@miguelgfierro 1 and 3 are already set up in the current code. I have created a PR for 2 here. |
Trigger nightly builds on PR to main
Optimized Spark recall_at_k time performance
Description
Related Issues
Checklist:
staging branch
and not tomain branch
.