Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GPU error in AzureML tests #1886

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Resolve GPU error in AzureML tests #1886

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cc36ad
debug gpu error
pradnyeshjoshi Feb 21, 2023
fb8ab4e
Merge branch 'staging' of https://github.com/microsoft/recommenders i…
pradnyeshjoshi Feb 21, 2023
915e2e0
debug gpu error
pradnyeshjoshi Feb 21, 2023
fcfaa7c
remove cudatoolkit and cudnn
pradnyeshjoshi Feb 21, 2023
9f83c45
remove env var
pradnyeshjoshi Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,6 @@ def create_run_config(
workspace,
add_gpu_dependencies,
add_spark_dependencies,
conda_pkg_cudatoolkit,
conda_pkg_cudnn,
conda_pkg_jdk,
conda_pkg_python,
reco_wheel_path,
Expand Down Expand Up @@ -202,14 +200,10 @@ def create_run_config(

# install extra dependencies
if add_gpu_dependencies and add_spark_dependencies:
conda_dep.add_conda_package(conda_pkg_cudatoolkit)
conda_dep.add_conda_package(conda_pkg_cudnn)
conda_dep.add_channel("conda-forge")
conda_dep.add_conda_package(conda_pkg_jdk)
conda_dep.add_pip_package("recommenders[dev,examples,spark,gpu]")
elif add_gpu_dependencies:
conda_dep.add_conda_package(conda_pkg_cudatoolkit)
conda_dep.add_conda_package(conda_pkg_cudnn)
conda_dep.add_pip_package("recommenders[dev,examples,gpu]")
elif add_spark_dependencies:
conda_dep.add_channel("conda-forge")
Expand Down Expand Up @@ -390,20 +384,6 @@ def create_arg_parser():
default="test_logs.log",
help="Test logs will be downloaded to this path",
)
# conda package name for cudatoolkit
parser.add_argument(
"--conda_pkg_cudatoolkit",
action="store",
default="cudatoolkit=11.2",
help="conda package name for cudatoolkit",
)
# conda package name for cudnn
parser.add_argument(
"--conda_pkg_cudnn",
action="store",
default="cudnn=8.1",
help="conda package name for cudnn",
)
# conda package name for jdk
parser.add_argument(
"--conda_pkg_jdk",
Expand Down Expand Up @@ -477,8 +457,6 @@ def create_arg_parser():
workspace=workspace,
add_gpu_dependencies=args.add_gpu_dependencies,
add_spark_dependencies=args.add_spark_dependencies,
conda_pkg_cudatoolkit=args.conda_pkg_cudatoolkit,
conda_pkg_cudnn=args.conda_pkg_cudnn,
conda_pkg_jdk=args.conda_pkg_jdk,
conda_pkg_python=args.conda_pkg_python,
reco_wheel_path=wheel_list[0],
Expand Down