-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in nightly spark: add env PYSPARK #1899
Conversation
Fix pyspark test
Nightly working: https://github.com/microsoft/recommenders/actions/runs/4563686982/jobs/8052496808 Kudos to @loomlike |
@@ -146,8 +147,7 @@ | |||
# | |||
"tests/smoke/examples/test_notebooks_pyspark.py::test_als_pyspark_smoke", # 49.53s | |||
"tests/integration/examples/test_notebooks_pyspark.py::test_als_pyspark_integration", # 110.58s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have other spark tests been passed with AzureML while the benchmark one failed? interesting....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, honestly, maybe it spark is an early evil AGI or something lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Description
Fix the error in the nightly build in the benchmark notebook for Spark
Related Issues
Fix #1898
References
Checklist:
staging branch
and not tomain branch
.