Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GRU4Rec references #2000

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Replace GRU4Rec references #2000

merged 4 commits into from
Sep 28, 2023

Conversation

miguelgfierro
Copy link
Collaborator

Description

Following the concerns of https://arxiv.org/abs/2307.14956, we removed the references to GRU4Rec.

The author's claims are that some settings included in the current Recommenders version, beyond the model part, are not strictly following the original paper.
image

Usually for research exploration, people’s goal is to explore which model structure is better, while leaving other training settings unified for fair comparison.

It is doable that we also add all the training tricks listed in the table into Recommenders, so that not only GRU4Rec, but other models can use them.

For now, we will remove all references to GRU4Rec to avoid misunderstandings.

We welcome the original authors or other people in the open source community to contribute the original version of GRU4Rec https://github.com/hidasib/GRU4Rec_PyTorch_Official

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. We need to update [13] here too in this README.md file.

[13] _Session-based Recommendations with Recurrent Neural Networks_, Balazs Hidasi, Alexandros Karatzoglou, Linas Baltrunas and Domonkos Tikk, ICLR 2016.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! fixing in the next commit

Signed-off-by: miguelgfierro <[email protected]>
@miguelgfierro miguelgfierro merged commit 48ebb26 into staging Sep 28, 2023
@miguelgfierro miguelgfierro deleted the gru_fix branch September 28, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants