-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GRU4Rec references #2000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
Signed-off-by: miguelgfierro <[email protected]>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
September 27, 2023 10:39
anargyri
reviewed
Sep 27, 2023
anargyri
reviewed
Sep 27, 2023
anargyri
reviewed
Sep 27, 2023
loomlike
approved these changes
Sep 28, 2023
examples/00_quick_start/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. We need to update [13] here too in this README.md file.
[13] _Session-based Recommendations with Recurrent Neural Networks_, Balazs Hidasi, Alexandros Karatzoglou, Linas Baltrunas and Domonkos Tikk, ICLR 2016.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! fixing in the next commit
anargyri
approved these changes
Sep 28, 2023
Signed-off-by: miguelgfierro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the concerns of https://arxiv.org/abs/2307.14956, we removed the references to GRU4Rec.
The author's claims are that some settings included in the current Recommenders version, beyond the model part, are not strictly following the original paper.
Usually for research exploration, people’s goal is to explore which model structure is better, while leaving other training settings unified for fair comparison.
It is doable that we also add all the training tricks listed in the table into Recommenders, so that not only GRU4Rec, but other models can use them.
For now, we will remove all references to GRU4Rec to avoid misunderstandings.
We welcome the original authors or other people in the open source community to contribute the original version of GRU4Rec https://github.com/hidasib/GRU4Rec_PyTorch_Official
Related Issues
References
Checklist:
staging branch
and not tomain branch
.