Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows support, including openssh and pageant agents; closes #19 #35

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Add Windows support, including openssh and pageant agents; closes #19 #35

merged 4 commits into from
Dec 20, 2021

Conversation

cr1cr1
Copy link
Contributor

@cr1cr1 cr1cr1 commented Dec 17, 2021

No description provided.

@cr1cr1
Copy link
Contributor Author

cr1cr1 commented Dec 17, 2021

pinging @kovetskiy @seletskiy

kovetskiy
kovetskiy approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@kovetskiy kovetskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. A few nitpicks and we're good to go.

I'll be glad to merge such a feature.

main.go Outdated Show resolved Hide resolved
sshagent_windows.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kovetskiy kovetskiy merged commit 6608ee9 into reconquest:master Dec 20, 2021
@kovetskiy
Copy link
Member

Thank you!

@cr1cr1 cr1cr1 mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kovetskiy kovetskiy kovetskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cr1cr1 @kovetskiy