[CodeQuality] Skip fopen() or die() on LogicalToBooleanRector on assi…

…gn (#6635)

* [CodeQuality] Skip fopen() or die() on LogicalToBooleanRector

* [CodeQuality] Skip fopen() or die() on LogicalToBooleanRector

* add assign condition to ensure patch on this specific use case

* trigger CI

* Temporary pin php-parser to 5.3.1

rules-tests/CodeQuality/Rector/LogicalAnd/LogicalToBooleanRector/Fixture/skip_fopen_or_die_in_assign.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\LogicalAnd\LogicalToBooleanRector\Fixture;
+
+final class SkipFopenOrDieInAssign
+{
+    public function run(string $fileLocation)
+    {
+        $file = fopen($fileLocation, 'w') or die('Unable to open file!');
+        fwrite($file, "John Doe\nJane Doe\n");
+        fclose($file);
+    }
+}

rules/CodeQuality/Rector/LogicalAnd/LogicalToBooleanRector.php

@@ -5,6 +5,7 @@
 namespace Rector\CodeQuality\Rector\LogicalAnd;
 
 use PhpParser\Node;
+use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
 use PhpParser\Node\Expr\BinaryOp\BooleanOr;
 use PhpParser\Node\Expr\BinaryOp\LogicalAnd;
@@ -51,8 +52,14 @@ public function getNodeTypes(): array
     /**
      * @param LogicalOr|LogicalAnd $node
      */
-    public function refactor(Node $node): BooleanAnd|BooleanOr
+    public function refactor(Node $node): BooleanAnd|BooleanOr|null
     {
+        $type = $this->nodeTypeResolver->getNativeType($node->left);
+
+        if ($node->left instanceof Assign && ! $type->isBoolean()->yes()) {
+            return null;
+        }
+
         return $this->refactorLogicalToBoolean($node);
     }