-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parallel] Fix missing process RemovedAndAddedFilesProcessor->run() on parallel process on WorkerRunner #3218
Conversation
Otherwise `RemovedAndAddedFilesCollector` will print something like the following and that would need to be baked into `expected-output.diff`: [NOTE] File "/home/user/Projects/rector-src/e2e/removed-and-added-files-collector/test" will be added
Currently failing when parallel running is enabled.
…n parallel process on PhpFileProcessor
it works 🎉 |
It may need an integration to run in |
When it apply on +! [NOTE] File "./removed-and-added-files-collector/test" will be added
+
+ ! [NOTE] File "./removed-and-added-files-collector/test" will be added
+
+ ! [NOTE] 1 files were added
+
+ so definatelly the integration usage is needed. |
Ok, so the parallel work on |
|
||
|
||
|
||
[OK] Rector is done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this [OK] Rector is done!
printed message should actually not exists with run with parallel along with:
$this->removedAndAddedFilesProcessor->run($configuration)
as it is running with --dry-run
, but probably need in separate PRs for improvement 👍 :)
Finally 🎉 All checks have passed 🎉 🎉 🎉 @TomasVotruba it is ready for review. |
While I am at it, I applied use |
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Thank you 🥳 |
@jtojnar this is on parallel process to: