Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Handle comment + single docblock on TypedPropertyFromAssignsRector #3264

Merged
merged 2 commits into from
Jan 2, 2023
Merged

[TypeDeclaration] Handle comment + single docblock on TypedPropertyFromAssignsRector #3264

merged 2 commits into from
Jan 2, 2023

Conversation

samsonasik
Copy link
Member

@TomasVotruba this is split PR of :

This ensure apply:

   // A comment
-    /**
-     * @var \DateTime
-     */

which keep comment, while removing @var.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 5b76f7b into main Jan 2, 2023
@TomasVotruba TomasVotruba deleted the do-not-remove-comment-split branch January 2, 2023 16:23
@TomasVotruba
Copy link
Member

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba