Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RenameClassNonPhpRector dependency to ClassRenamingPostRector #3360

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Added RenameClassNonPhpRector dependency to ClassRenamingPostRector #3360

merged 2 commits into from
Feb 8, 2023

Conversation

grandmaster44
Copy link
Contributor

@grandmaster44 grandmaster44 commented Feb 8, 2023 •
edited by samsonasik
Loading

@grandmaster44 grandmaster44 mentioned this pull request Feb 8, 2023
Closed
@samsonasik
Copy link
Member

Could you cherry-pick commit e8a4d77 to fix CI build? Latest phpunit 10.0.6 broke paratest so use normal phpunit seems the way to go.

samsonasik
samsonasik approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit b999639 into rectorphp:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RenameClassNonPhpRector
3 participants
@grandmaster44 @samsonasik @TomasVotruba