-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeadCode] Remove property comment same line on RemoveUnusedPrivatePropertyRector #3547
Conversation
@staabm this is a quick solution, the general solution probably on the |
All checks have passed 🎉 @TomasVotruba it is ready for review. |
@staabm another general solution is probably create a dedicated rector rule to verify the Stmt just removed with next is Nop in the same line, eg: that will work on usage on other rule as well :) |
Thanks for working on it. I can't tell which works best for rector. I have no experience with Nop AST nodes either. |
I will create alternative PR for it 👍 |
Checking stmt just removed in loop of StmtsAwareInterface probably make memory hog as it will compare object in array, so probably not best solution. |
…opertyRector (#3547) Co-authored-by: Markus Staab <[email protected]> Co-authored-by: GitHub Action <[email protected]>
Closes #3539