Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip used on Closure use next stmt on RemoveUnusedVariableAssignRector #4042

Merged
merged 3 commits into from
Jun 2, 2023
Merged

[DeadCode] Skip used on Closure use next stmt on RemoveUnusedVariableAssignRector #4042

merged 3 commits into from
Jun 2, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 2, 2023 00:47
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @spawnia

@samsonasik samsonasik force-pushed the skip-used-on-closure-use branch from dacb562 to 96f3106 Compare June 2, 2023 00:54
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 495900a into main Jun 2, 2023
@samsonasik samsonasik deleted the skip-used-on-closure-use branch June 2, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoveUnusedVariableAssignRector does not consider variables bound by reference
1 participant
@samsonasik