Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector #4107

Merged
merged 9 commits into from
Jun 7, 2023
Merged

[CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector #4107

merged 9 commits into from
Jun 7, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 7, 2023 •
edited
Loading

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 7, 2023 13:42
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @jlherren

@samsonasik samsonasik changed the title [CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector [CodeQuality] Skip throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector Jun 7, 2023
@samsonasik samsonasik changed the title [CodeQuality] Skip throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector [CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector Jun 7, 2023
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 63816c0 into main Jun 7, 2023
@samsonasik samsonasik deleted the throw-after-if branch June 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ConsecutiveNullCompareReturnsToNullCoalesceQueueRector
2 participants
@samsonasik @actions-user